Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Services::request() should call AppServices instead static #7985

Merged
merged 1 commit into from
Sep 28, 2023
Merged

fix: Services::request() should call AppServices instead static #7985

merged 1 commit into from
Sep 28, 2023

Conversation

pjsde
Copy link
Contributor

@pjsde pjsde commented Sep 26, 2023 •
edited
Loading

CodeIgniter\Config\Services::request() should return Config\Services::incomingrequest() instead of static::incomingrequest() to allow override the IncomingRequest

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 27, 2023
@kenjis kenjis merged commit f62e6cf into codeigniter4:develop Sep 28, 2023
61 checks passed
@kenjis
Copy link
Member

kenjis commented Sep 28, 2023

@pjsde Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis kenjis approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjsde @kenjis @paulbalandan